Add flow migrate state command
#1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jribbink
changed the title
jribbink
changed the title
flow migrate state command to migrate emulator state to Cadence 1.0
jribbink
changed the title
flow migrate state command to migrate emulator state to Cadence 1.0flow migrate state command
This was referenced Feb 26, 2024
turbolent
approved these changes
Feb 27, 2024
internal/migrate/state.go
Outdated
| return nil, fmt.Errorf("failed to open database: %w", err) | ||
| } | ||
|
|
||
| rwf := &migration.NOOPReportWriterFactory{} |
There was a problem hiding this comment.
We'll probably want some kind of writer here to provide feedback to the developer
There was a problem hiding this comment.
Sounds good, I'll see how I can surface it.
There was a problem hiding this comment.
I added a --save-report flag - open to feedback here about naming/acceptable defaults. Assumed it's probably best not to pollute user's workspace if not manually specified (so default to NOOP) but can change if wanted.
turbolent
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf,
bluesign,
bjartek and
ianthpun
as code owners
SupunS
approved these changes
Mar 6, 2024
chasefleming
approved these changes
Mar 8, 2024
|
Should be good to go once #1450 is in |
|
Think that should be OK. We can have the same params as in https://github.com/onflow/flow-emulator/pull/608/files#diff-717939af182d8688c65dd7e4a5b5471360a4e3719f2dba0b34629167f3ce70afR97-R104. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1433
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer